oxidecomputer / oxidecomputer/dropshot

Migration to schemars 1.0

Open
#1,375 5 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.2k
Forks
104
Avg merge
1d 19h
Merged PRs (30d)
22

Description

Schemars 1.0 has been out for about two months now and adds some interesting features, like support for garde as an alternative to validator.

Per #1336, migration wasn't desired at the time, but I'm wondering if that's still the case now that schemars has continued to mature.

I took a quick look and think the migration might be doable in roughly a day's work, though I haven't dug into all the details yet. One important aspect is that 1.0 does make heavy use of Cow<'static, str> though.

Is there interest in migrating to 1.0 in the near-future at all? Happy to investigate further and work on it if so.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the repository's current schemars integration and the discussion in #1336 first. Investigate the schemars 1.0 migration, including its Cow<'static, str> usage and garde support, then document the affected areas and confirm whether the migration is wanted before proposing implementation work.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend-api-design
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.