oxidecomputer / oxidecomputer/dice-util

use camino

Open
#308 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
11
Forks
3
Avg merge
2d 3h
Merged PRs (30d)
16

Description

We don't have any use-case that requires support for non-UTF8 characters in file paths but we're using Path & PathBuf which require effectively ignoring / dropping non-UTF8 characters. So our impl will fail to work on systems that have non-UTF8 characters in file system paths despite us doing this extra work. We're probably better off using camino and explicitly disallowing non-UTF8 file paths completely. This larger task is derived from #306 that replaced our use of the std types w/ camino in the attest-mock cli while also refactoring attest-mock to provide a library / API.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #306 and the attest-mock CLI changes it describes, then inspect the repository's uses of std Path and PathBuf. Done means the relevant path handling uses camino and explicitly rejects non-UTF8 filesystem paths without leaving inconsistent standard-path APIs behind.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.