oxidecomputer / oxidecomputer/dice-util

API breaking changes when updating ron 0.8 -> 0.10

Open
#258 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
11
Forks
3
Avg merge
2d 3h
Merged PRs (30d)
16

Description

ron is only used in the yhsm-audit which is barely a WIP so low impact

error[E0277]: the trait bound `W: std::fmt::Write` is not satisfied
   --> yhsm-audit/src/main.rs:228:13
    |
227 |         Encoding::Ron => ser::to_writer_pretty(
    |                          --------------------- required by a bound introduced by this call
228 |             writer.borrow_mut(),
    |             ^^^^^^^^^^^^^^^^^^^ the trait `std::fmt::Write` is not implemented for `W`
    |
    = note: required for `&mut W` to implement `std::fmt::Write`
note: required by a bound in `ron::ser::to_writer_pretty`
   --> /home/flihp/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ron-0.10.1/src/ser/mod.rs:36:8
    |
34  | pub fn to_writer_pretty<W, T>(writer: W, value: &T, config: PrettyConfig) -> Result<()>
    |        ---------------- required by a bound in this function
35  | where
36  |     W: fmt::Write,
    |        ^^^^^^^^^^ required by this bound in `to_writer_pretty`
help: consider further restricting type parameter `W` with trait `Write`
    |
214 | fn serialize<T: Serialize, W: Write + std::fmt::Write>(
    |                                     +++++++++++++++++

For more information about this error, try `rustc --explain E0277`.
error: could not compile `yubihsm-audit` (bin "yubihsm-audit") due to 1 previous error

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at yhsm-audit/src/main.rs:214-228 and inspect serialize and its writer bounds, using the ron 0.10 requirement shown in the compiler error. Run the yhsm-audit build or check command and confirm that compilation succeeds after the API update.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.