oxidecomputer / oxidecomputer/dendrite
dpd should accumulate data from clear-on-read counters
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 20
- Forks
- 3
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 4
Description
When accessing some tofino counters, the ASIC clears the values after reading them. This means that historical data will be lost, and multiple admins servicing the same switch will be getting incomplete information.
When dpd reads counters in response to a swadm request, the values should be accumulated in an in-core cache. We can then use the accumulated date to either return the total counter values or just that data generated since the last read.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing dpd's swadm counter-read path and the Tofino handling for clear-on-read counters; the issue does not name specific files or tests. Inspect how counter values are represented and whether an in-core cache already exists. Done means repeated reads preserve historical values and can return either accumulated totals or data since the previous read.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100