oxidecomputer / oxidecomputer/dendrite
Revisiting `reset_all` and `reset_all_tagged`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 20
- Forks
- 3
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 4
Description
dpd-api currently marks both these with "TODO-security: This endpoint should probably not exist."
I'm making adjacent changes to resource tagging, and I'd like to know whether to version-migrate the tagged endpoints or sunset them both. If the former, I'd like to replace the TODO comments. If the latter, I'll open a PR for removal.
tfportd is the only user I've found so far. Not clear to me how to migrate this if we decide to delete the endpoints. Open to suggestions.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read dpd-api/src/lib.rs around lines 1544-1573 and trace the reset_all and reset_all_tagged endpoints. Then inspect their only identified user in tfportd/src/main.rs around lines 296-302. Done means deciding whether to version-migrate or remove the endpoints, resolving the tfportd impact, and replacing the TODO comments or completing the removal.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100