oxidecomputer / oxidecomputer/dendrite
`swadm link serdes set tx-eq` should require at least one gain value
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 20
- Forks
- 3
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 4
Description
See:
The comment says that swadm link serdes set tx-eq requires at least one value for the gains. That's a good idea, but the code actually lets you set none of them, in which case they're all defaulted to zero. We should disallow that, and require at least one.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with swadm/src/link.rs at the referenced lines for the swadm link serdes set tx-eq command. Check how the gain arguments are validated, then exercise the command with no gain values and with at least one value. Done means the empty invocation is rejected while an invocation containing a gain remains accepted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100