oxidecomputer / oxidecomputer/dendrite

`port_settings_apply` does not update tx-eq settings

Open
#135 0 comments 0 reactions 1 assignee View on GitHub

@rcgoodfellow is already working on this.

Since Sep 24, 2025.

Dominant language
Rust
Stars
20
Forks
3
Avg merge
3d 11h
Merged PRs (30d)
4

Description

First noticed debugging #104

If we create a link with port_settings_apply and then attempt to update tx-eq settings on a subsequent call, nothing happens.

Settings do not change for existing link

root@oxz_switch1:~# ./swadm link apply --link qsfp11/0 --tag muffins --speed 100g --fec rs
root@oxz_switch1:~# ./swadm link sd get tx-eq qsfp11/0
           lane 0     lane 1     lane 2     lane 3
pre2      0 (  0)    0 (  0)    0 (  0)    0 (  0)
pre1      0 (  0)    0 (  0)    0 (  0)    0 (  0)
main     26 ( 26)   26 ( 26)   26 ( 26)   26 ( 26)
post1     0 (  0)    0 (  0)    0 (  0)    0 (  0)
post2     0 (  0)    0 (  0)    0 (  0)    0 (  0)
root@oxz_switch1:~# ./swadm link apply --link qsfp11/0 --tag muffins --speed 100g --fec rs --main 7
root@oxz_switch1:~# ./swadm link sd get tx-eq qsfp11/0
           lane 0     lane 1     lane 2     lane 3
pre2      0 (  0)    0 (  0)    0 (  0)    0 (  0)
pre1      0 (  0)    0 (  0)    0 (  0)    0 (  0)
main     26 ( 26)   26 ( 26)   26 ( 26)   26 ( 26)
post1     0 (  0)    0 (  0)    0 (  0)    0 (  0)
post2     0 (  0)    0 (  0)    0 (  0)    0 (  0)

But if you delete the link and create it with a particular tx-eq cursor value from the beginning, that takes

root@oxz_switch1:~# ./swadm link del qsfp11/0
root@oxz_switch1:~# ./swadm link apply --link qsfp11/0 --tag muffins --speed 100g --fec rs --main 7
root@oxz_switch1:~# ./swadm link sd get tx-eq qsfp11/0
           lane 0     lane 1     lane 2     lane 3
pre2      0 (  0)    0 (  0)    0 (  0)    0 (  0)
pre1      0 (  0)    0 (  0)    0 (  0)    0 (  0)
main      7 (  7)    7 (  7)    7 (  7)    7 (  7)
post1     0 (  0)    0 (  0)    0 (  0)    0 (  0)
post2     0 (  0)    0 (  0)    0 (  0)    0 (  0)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.