oxidecomputer / oxidecomputer/crucible

`ImpactedBlockIter` should return an `ImpactedAddr`

Open
#936 0 comments 0 reactions 1 assignee View on GitHub

@faithanalog is already working on this.

Since Sep 21, 2023.

Dominant language
Rust
Stars
260
Forks
34
Avg merge
2d 1h
Merged PRs (30d)
8

Description

For historical reasons, ImpactedBlocks::blocks(...) returns an ImpactedBlockIter, which provides tuples of (u64, Block). It would be more clear to have the iterator return ImpactedAddr.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.