oxidecomputer / oxidecomputer/crucible
Block size is stored in two places in `RegionDefinition`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 260
- Forks
- 34
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 8
Description
In a RegionDefinition, the block size is stored both in block_size (as bytes) and in extent_size.shift (as a shift).
We don't check that they match!
block_size is used for total_size(); extent_size.shift is used in extent_from_offset(..). We should remove this duplication, either by making extent_size a single u64 (instead of a Block) or removing block_size.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate RegionDefinition and trace the uses of block_size, extent_size.shift, total_size(), and extent_from_offset(..). Review both proposed representations and their callers before choosing one; done means the duplicated block-size state is removed while both size calculations retain their intended behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100