oxidecomputer / oxidecomputer/crucible

tools/test_reconnect.sh may not be able to finish

Open
#822 0 comments 0 reactions 1 assignee View on GitHub

@leftwo is already working on this.

Since Jun 29, 2023.

Dominant language
Rust
Stars
260
Forks
34
Avg merge
2d 1h
Merged PRs (30d)
8

Description

the tools/test_reconnect.sh test can get itself stuck by restarting too fast, which can result in
the test never finishing. If we send enough IO when a downstairs is off, the upstairs will kick it
out and require LiveRepair. This results in things taking longer before that downstairs is back
to Active. If another downstairs goes away during this, then that means it will take even longer
before everything is back to normal.

This test was a test for the replay functionality, and in its current form it may not be able to
test that.

There is now a crutest replay option that does what we need, so this test (test_reconnect.sh)
should probably be abandoned and a new test developed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.