oxidecomputer / oxidecomputer/crucible
dsc cleanup should be smarter for region directories
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 260
- Forks
- 34
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 8
Description
If a --region-dir is specified plus a --cleanup, dsc will delete the region directory.
This can have unintended consequences if the directory provided is also used for other
things, like /var/tmp.
dsc should delete anything inside the region-dir that it intends to create, but leave
the top level directory (and anything else in it) alone.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementation of the --region-dir and --cleanup options, then trace which paths dsc creates and removes. Reproduce cleanup with a region directory containing unrelated files; done means dsc removes only its own contents while preserving the top-level directory and everything else in it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100