oxidecomputer / oxidecomputer/crucible
pantry tests need fewer external requirements
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 260
- Forks
- 34
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 8
Description
Some of the pantry tests pull from an external URL, which requires internet access to work.
test_pantry_import_from_url_ovmf_bad_digest()
test_pantry_import_from_url_ovmf()
test_pantry_scrub()
Update these tests to maybe make their own web server then pull from it?
The timeout can also be too short, which results in intermittent test failures.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating and running test_pantry_import_from_url_ovmf_bad_digest(), test_pantry_import_from_url_ovmf(), and test_pantry_scrub(). Replace their external URL dependency with a test-local web server and address the intermittent timeout failures; done means the tests run reliably without internet access.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100