oxidecomputer / oxidecomputer/crucible
should_panic tests in upstairs/src/test.rs need work
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 260
- Forks
- 34
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 8
Description
Make sure that #[should_panic] tests are panic'ing in the place we expect it to, instead of in some earlier setup.
Originally posted by @leftwo in https://github.com/oxidecomputer/crucible/pull/449#discussion_r977058830
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read upstairs/src/test.rs and inspect each #[should_panic] test, focusing on whether setup can panic before the intended operation. Run the relevant tests and confirm each test fails for the expected panic location rather than an earlier setup failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100