oxidecomputer / oxidecomputer/crucible

fix comment in gw_ds_complete

Open
#455 0 comments 0 reactions 1 assignee View on GitHub

@leftwo is already working on this.

Since Sep 22, 2022.

Dominant language
Rust
Stars
260
Forks
34
Avg merge
2d 1h
Merged PRs (30d)
8

Description

I was not 100% sure we can remove here. Though, I did try as I could, and I was not able to create a scenario where this method is called with a gw_id that is not on the active list. I wonder if the comment above (that I'm sure I wrote) reflected a possible situation that no longer exists.

Originally posted by @leftwo in https://github.com/oxidecomputer/crucible/pull/449#discussion_r975918796

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.