oxidecomputer / oxidecomputer/crucible
There should be a dss per upstairs connection
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 260
- Forks
- 34
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 8
Description
complete_work_stat is passed a corresponding UpstairsConnection, but there is only one DsStatOuter for the whole Downstairs. There should be one of these stat related objects per connection (should maybe be moved into ActiveUpstairs?).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing complete_work_stat and how its corresponding UpstairsConnection reaches DsStatOuter. Compare the current whole-Downstairs ownership with ActiveUpstairs and determine where one stats object per connection should live. Done means the ownership and lifecycle are consistent for every connection, with relevant existing tests updated or added.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100