Don't log empty dependency lists

Open
#1,958 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
58/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Quiet
Tech stack
rust
Domain
observability

Research direction

Locate the code that emits the “final dependency list” log and inspect how it represents empty versus non-empty dependency lists. Change the logging behavior so empty lists are omitted while lists containing dependencies remain logged, then run the relevant existing tests or logging checks if available.

Written by the indexing model from the issue text.

Description

This log shows up sometimes:

2026-07-14 16:44:44.287Z INFO propolis-server/22395 (vm_state_driver) on oxz_propolis-server_b505f9e0-c826-4863-9c95-4e42d6b96064:  747715164 final dependency list [[]]
     = downstairs
    client = 0
    session_id = 5fcc39f8-a485-4ec1-85d4-5a714c6c6fec

This is probably not worth logging, as just the absence of the log can give you the information. We can still log if there are deps, and as many of these logs are when there are no deps, it would reduce the amount of logs we need to display and comb through.

Dominant language
Rust
Stars
260
Forks
34
Avg merge
2d 1h
Merged PRs (30d)
8

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from oxidecomputer/crucible

All issues in oxidecomputer/crucible

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.