oxidecomputer / oxidecomputer/crucible
Change name of "extent_size" in Crucible Agent API
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 260
- Forks
- 34
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 8
Description
According to @leftwo 's comment: https://github.com/oxidecomputer/omicron/pull/511#discussion_r787191192
In Crucible, extent_size is the number of block_size parts that make up a single extent. (It is not a good name, agreed).
I misinterpreted the name "extent_size" to mean "size of an extent, in bytes".
Could we change the name to reflect that it is a count, not a size?
I'd suggest something like: blocks_per_extent
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Crucible Agent API definition and search the repository for extent_size, using the linked discussion for context. Rename the field to a count-based name and update its references; done means the API and its consumers no longer use the misleading name and relevant checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100