oxidecomputer / oxidecomputer/crucible
process_ds_operation() method failure is ignored.
Open
Nobody has claimed this yet.
mvp
- Dominant language
- Rust
- Stars
- 260
- Forks
- 34
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 8
Description
In upstaris/src/lib.rs, process_message() method, we call process_ds_operation()
If process_ds_operaion() fails, we just ignore it and continue.
The error should at least be printed if not handled, as it is now, it's silently ignored.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in upstaris/src/lib.rs at process_message() and trace the call to process_ds_operation(). Check how nearby failures are handled and run the repository's relevant checks. Done means a failure from process_ds_operation() is no longer silently ignored, matching the issue's stated requirement.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100