oxidecomputer / oxidecomputer/crucible

Some BlockOps need more logic at the Volume layer

Open
#1,455 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
260
Forks
34
Avg merge
2d 1h
Merged PRs (30d)
8

Description

Some BlockOp enums might need to be updated to provide additional context.

Specifically:

    QueryExtentSize {                                                           
        done: BlockRes<Block>,                                                  
    },                                                                          
    QueryWorkQueue {                                                            
        done: BlockRes<WQCounts>,                                               
    },                                                                          
    ShowWork {                                                                  
        done: BlockRes<WQCounts>,                                               
    }
```

These block ops make sense when a single upstairs exists behind the object that supports the trait.
For example, `Guest` only ever has three downstairs and one work queue.

However, with a `Volume`, you could have multiple sub-volumes and a read only parent.  So what is returned in this case can no longer be represented by a single object, or if it is, it has lost some information that the caller might want.
In the case of `QueryExtentSize`, a single value here for a `Volume` is only correct if everyone happens to share the same extent size, or if there is only a single sub volume.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the BlockOp definitions and the Volume and Guest implementations that handle QueryExtentSize, QueryWorkQueue, and ShowWork. Compare the information available for single and multiple sub-volumes, then document a representation that preserves the needed context and update the relevant tests to verify it.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.