oxidecomputer / oxidecomputer/crucible
Upstairs isn't sending the final repair progress notification
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 260
- Forks
- 34
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 8
Description
Alan reported his omdb showed:
Repair notifications
TIME REPAIR_ID REPAIR_TYPE UPSTAIRS_ID SESSION_ID NOTIFICATION_TYPE
2024-05-28 21:02:57.786939 UTC a661e5b9-0735-4ff6-a318-693349460b4b Live 23776670-5d21-449f-9552-efad0fe32b2a dd90808a-ff3b-41d0-a273-6a64e820458c Started
2024-05-28 21:08:21.759356 UTC a661e5b9-0735-4ff6-a318-693349460b4b Live 23776670-5d21-449f-9552-efad0fe32b2a dd90808a-ff3b-41d0-a273-6a64e820458c Succeeded
progress: █████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████░ [ 799/ 800]
This means that the Upstairs sent the "finished" notification but not the final progress update notification. Fix this bug instead of having omdb print the full bar.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests; start by locating the repair progress and notification handling in the Crucible codebase and reproduce the shown 799/800 output. Compare the final progress update with the finished notification, then verify that the final progress notification is emitted so omdb no longer needs to print the full bar.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100