oxidecomputer / oxidecomputer/crucible
Upstairs should use per-volume rayon pool
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 260
- Forks
- 34
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 8
Description
As part of the effort in oxidecomputer/propolis#686 to limit the number of worker threads spawned by a propolis instance, it would be nice if the rayon calls in the upstairs used a per-volume thread pool rather than the (implicit) global one. The latter defaults to number-of-host-CPUs threads, and is a bit challenging to initialize (with a lower count) in a safe manner.
Using a per-volume thread pool would mean that the thread count would scale with the number of volumes, and would be of a more appropriate size, particularly on large machines.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the rayon calls in the upstairs and tracing how volumes are created and managed. Determine how a per-volume thread pool would be owned and sized; done means upstairs rayon work uses per-volume pools instead of the implicit global pool, with thread counts appropriate to each volume.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100