oxidecomputer / oxidecomputer/crucible
Remove the option of sending jobs without a corresponding `BlockReq`
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 260
- Forks
- 34
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 8
Description
At some point I'd like to remove the option of sending jobs without a corresponding BlockReq, to avoid all of this Bonus Code (which is only used in the test suite).
Originally posted by @mkeeter in https://github.com/oxidecomputer/crucible/pull/1066#discussion_r1440566278
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how jobs are sent with and without a corresponding BlockReq, then inspect the Bonus Code used only by the test suite. Identify the affected tests and callers before changing the behavior. Done means jobs no longer support the missing-BlockReq path and the obsolete test-only code is removed or updated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100