oxidecomputer / oxidecomputer/console
Add transit IPs to NIC create form
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 228
- Forks
- 22
- Avg merge
- 19h 42m
- Merged PRs (30d)
- 32
Description
Should be easy: the update form already has them, but the create form could not because the transit IPs key was left out of the create request body. I fixed that in https://github.com/oxidecomputer/omicron/pull/8851, so now we can add it to the create form as well.
Note this will be affected by #2878 since we will probably want to use the new input table for this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in app/forms/network-interface-edit.tsx around lines 98-149 and compare the existing update form with the create form request body. Check #2878 for the planned input-table changes; done means the create form accepts transit IPs and includes them in its create request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100