oxidecomputer / oxidecomputer/console
`PropertiesTable` row order appears different when 1 col vs 2
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 228
- Forks
- 22
- Avg merge
- 19h 42m
- Merged PRs (30d)
- 32
Description
Noticed in https://github.com/oxidecomputer/console/pull/2838#pullrequestreview-2995337226.
It seems like the elimination of PropertiesTable.Group in #2723 means we have an ordering problem. We write the code to represent the cells left to right. We might be able to fix this by changing the component so it goes by column instead of by row. We'd have to update all the existing call sites.
Two columns
One column
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the PropertiesTable component and the SledPage.tsx example at lines 47–61. Compare the rendered ordering with one and two columns, then review the existing call sites that must be updated. Done means cell order is consistent across column layouts and all affected call sites still render correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100