oxidecomputer / oxidecomputer/console
Replace Listbox in Create Disk side modal with Combobox
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 228
- Forks
- 22
- Avg merge
- 19h 42m
- Merged PRs (30d)
- 32
Description
I was working on #2776 and noticed that — once alphabetizing the mock API responses — some of the tests failed. It seems that our ListboxField component has a cap on results, and, when selecting a snapshot, some of the snapshots were no longer available.
I haven't looked into this, but would hope that by using a combobox there we could let the user filter for the desired snapshot name.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Create Disk side modal and trace its snapshot selector, including the ListboxField component and the mock API response tests mentioned in the issue. Replace the capped selection behavior with a combobox that lets users filter and select any snapshot by name, then confirm the affected tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100