oxidecomputer / oxidecomputer/console

Update the mock API to alphabetize paginated list queries

Open
#2,776 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
228
Forks
22
Avg merge
19h 42m
Merged PRs (30d)
32

Description

The API will automatically sort items by name ascending if no sort_by query param is included to override that. We should update the paginated helper in the mock API to match this behavior. [Investigate this to verify, but it's likely correct.]

(From a PR)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the referenced common/src/api/external/http_pagination.rs and nexus/src/external_api/http_entrypoints.rs lines first to verify the production ordering. Then locate the mock API's paginated helper and its relevant tests. Done means paginated list results default to ascending name order while an explicit sort_by override still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.