oxidecomputer / oxidecomputer/console
OxQL metrics: don't cut off the part of the time range with no data
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 228
- Forks
- 22
- Avg merge
- 19h 42m
- Merged PRs (30d)
- 32
Description
I started an instance and messed with it a bit to test the charts. I made the time range 3 hours, including time before the instance existed and in the future. The time before comes back with no data, while the time in the future comes back with nulls. We treat these differently: we display the nulls but not the nothing.
I'm not 100% sure whether we should always display the full range asked for — on one hand I was pretty confused about why my graph started at a time other than the one I put in the picker. On the other hand, if you ask for a big range and there's only data for a little bit of it, you get a pretty useless graph. On the third and hopefully final hand, in that situation the user can simply change the time range to zoom in on the relevant slice. (This rules out bad ideas I had like a checkbox about whether to show the full range or only spots where we have actual data. That's hard to explain and, more importantly, covered by the existing controls.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the OxQL metrics chart with a range spanning before instance creation and into the future, then trace how empty results and nulls are handled. No files, tests, or entry points are named, and the expected full-range behavior remains undecided; confirm that decision before defining done.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- data-visualization, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100