oxidecomputer / oxidecomputer/console
Fix HMR
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 228
- Forks
- 22
- Avg merge
- 19h 42m
- Merged PRs (30d)
- 32
Description
HMR doesn’t work at all. Totally my fault: https://github.com/oxidecomputer/console/pull/2545 exports components and loaders from the same file, which breaks HMR. Those route files are all the top level files and HMR is broken for any changes below them, so it’s broken for all changes. This is annoying because it takes a few seconds to see a change instead of like 50ms, and it refreshes the page, losing any client-side state.
That change was meant to prepare us for RR v7 in framework mode + SPA mode, but I’m not sure how feasible that is for us. So we need to determine whether we plan to move to that, and if not, switch all the route files back to sticking loader on PageComponent.loader.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review pull request #2545 and the top-level route files to understand how exporting components and loaders together affects HMR. Determine whether the project will use RR v7 framework and SPA modes; if not, the issue identifies moving loaders back onto PageComponent.loader as the expected outcome.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100