Test flake: firefox instance create

https://github.com/oxidecomputer/console/actions/runs/13311639509/job/37175446887

Refreshingly, I was actually able to repro the failure locally with

e2e --project=firefox instance-create -g 'changing tabs' --repeat-each 10

2 of the 10 runs failed.

  1) [firefox] › test/e2e/instance-create.e2e.ts:388:1 › maintains selected values even when changing tabs 

    Test timeout of 120000ms exceeded.

    Error: locator.click: Test timeout of 120000ms exceeded.
    Call log:
      - waiting for getByRole('option', { name: 'arch-2022-06-01' })
        - locator resolved to <div role="option" tabindex="-1" data-focus="" data-active="" aria-selected="false" data-headlessui-state="active focus" id="headlessui-combobox-option-:r55:" class="relative border-b border-secondary last:border-0">…</div>
      - attempting click action
        2 × waiting for element to be visible, enabled and stable
          - element is visible, enabled and stable
          - scrolling into view if needed
          - done scrolling
          - <div class="flex h-20 items-center gutter">…</div> from <div id="root">…</div> subtree intercepts pointer events
        - retrying click action
        - waiting 20ms
        2 × waiting for element to be visible, enabled and stable
          - element is visible, enabled and stable
          - scrolling into view if needed
          - done scrolling
          - <div class="flex h-20 items-center gutter">…</div> from <div id="root">…</div> subtree intercepts pointer events
        - retrying click action
          - waiting 100ms
        178 × waiting for element to be visible, enabled and stable
            - element is visible, enabled and stable
            - scrolling into view if needed
            - done scrolling
            - <div class="flex h-20 items-center gutter">…</div> from <div id="root">…</div> subtree intercepts pointer events
          - retrying click action
            - waiting 500ms


      395 |   await imageSelectCombobox.fill('arch')
      396 |   // select the image
    > 397 |   await page.getByRole('option', { name: arch }).click()
          |                                                  ^
      398 |   // expect to find name of the image on page
      399 |   await expect(imageSelectCombobox).toHaveValue(arch)
      400 |   // change to a different tab
        at /Users/runner/work/console/console/test/e2e/instance-create.e2e.ts:397:50

The trace suggests it's something to do with failing to scroll all the way into view.

Reproduce the failure with e2e --project=firefox instance-create -g 'changing tabs' --repeat-each 10, then inspect test/e2e/instance-create.e2e.ts around line 397 and the linked trace. Focus on the image option click while changing tabs; done means the test no longer flakes across repeated Firefox runs.