oxidecomputer / oxidecomputer/console
Make it harder to forget to submit targets/filters subform
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 228
- Forks
- 22
- Avg merge
- 19h 42m
- Merged PRs (30d)
- 32
Description
@iliana reports (and I think @charliepark have discussed this before) that it feels like the firewall rules form is just ignoring your target because you typed it in but forgot to click Add Target. There is probably something we can do about this. It's probably too much to refuse to submit the overall form if there's unsubmitted stuff in the target or filter field, but we can probably warn the user somehow.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the firewall rules form and its target and filter subforms, then reproduce submitting text without clicking Add Target. Trace how those fields are handled on overall form submission and choose a warning behavior consistent with the existing UI. Done means users are alerted that target or filter input remains unsubmitted instead of silently losing it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100