oxidecomputer / oxidecomputer/console

Change body text color to `text-secondary`

Open
#2,206 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tools
Dominant language
TypeScript
Stars
228
Forks
22
Avg merge
19h 42m
Merged PRs (30d)
32

Description

No urgency to this — might make more sense to do after doing a pass on colors overall.


We use text-secondary 79 times in the console, to the point where it's hard to find text that changes color when you change the following line to text-secondary:

https://github.com/oxidecomputer/console/blob/e8e4f576e6ee5c3e3544eaf5230a71e07c79a428/app/ui/styles/index.css?plain=1#L50-L51

Some effects were arguably improvements, like these date pickers. Maybe not.

image

One thing that turned gray and clearly shouldn't was the form input labels and modal title. But it would probably make more sense to annotate these few things with that color directly.

image image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with app/ui/styles/index.css around lines 50-51 and review the console's uses of text-secondary. Compare the date pickers, form input labels, and modal title shown in the issue to identify text that should retain its existing color. Done means the body text uses text-secondary while those exceptions remain visually appropriate.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, typescript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.