oxidecomputer / oxidecomputer/console

Mock API: lookup by ID should fail if parent is specified

Open
#2,202 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tools
Dominant language
TypeScript
Stars
228
Forks
22
Avg merge
19h 42m
Merged PRs (30d)
32

Description

This is what the API does. The lack of this resulted in us not catching #2201. In #2203 I did this for floating IPs, but we should do it for all lookup functions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Mock API lookup functions and compare the behavior described here with the floating-IP work in issue #2203; issue #2201 provides the missed-case context. Check the relevant lookup tests or add coverage where they exist, with completion shown by lookups failing when a specified parent does not match.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.