oxidecomputer / oxidecomputer/console

create more robust "+N with modal" component, use in External IPs on instance page

Open
#2,172 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
228
Forks
22
Avg merge
19h 42m
Merged PRs (30d)
32

Description

We have a pattern we're able to use with the <ListPlusCell> component, where we roll up some arbitrary number of extra items into a tooltip. We need to have a similar component we can use when the contents of the roll-up need to be interactive. Accessibility rules dictate that an interactive element (like a button or a link) can't be nested inside another interactive element (like a tooltip or other visible-on-hover element).

One place where we can use this is in the Instance page's header, where we list the External IPs, each with a link and a click-to-copy button. We should be able to list some number (2–3), with a +4 (or whatever) button that opens a modal listing the other IPs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the existing component and the Instance page header where External IPs are displayed. Trace how the links and click-to-copy buttons are rendered, then verify that the new reusable pattern shows a small set of IPs and opens the remaining interactive items in a modal without nested interactive elements.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
accessibility, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.