oxidecomputer / oxidecomputer/console

Network interface create form improvements

Open
#2,147 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

polish
Dominant language
TypeScript
Stars
228
Forks
22
Avg merge
19h 42m
Merged PRs (30d)
32

Description

After #2146, I checked and saw we do have one IP field left, in the network interface create form. I think it can stay in because it's a private IP, so it's a lot easier to pick a valid one at random. but we can improve the form in a few ways:

  • Auto select first VPC and subnet, they should almost always be what you want
  • Collapse VPC, subnet, and address fields under Advanced
  • Validate IP address with validateIp

https://github.com/oxidecomputer/console/blob/5cae21111346e13d926f212042b5fe7159abd97d/app/forms/network-interface-create.tsx#L82-L87

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in app/forms/network-interface-create.tsx around the linked lines and inspect the existing VPC, subnet, address fields and validateIp usage. Done means the first VPC and subnet are selected automatically, those fields are collapsed under Advanced, and the private IP is validated with validateIp.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.