oxidecomputer / oxidecomputer/console
Allow doc links section in confirm modals
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 228
- Forks
- 22
- Avg merge
- 19h 42m
- Merged PRs (30d)
- 32
Description
Practically: I want to add docs links to the detach floating IP confirm modal (and probably more modals).
Right now it's not possible to get another section in there because we hard-code wrapping the content in a section. Need to either add a second key on action config for a docs section or require the caller to wrap the contents in Modal.Section. I prefer to keep props free-from and let callers handle it but I'll have to see how it looks in practice.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with app/components/ConfirmActionModal.tsx around lines 27-32 and app/stores/confirm-action.ts around lines 11-20 to understand how modal content is wrapped and configured. Verify the detach floating IP confirm modal can provide a separate documentation-links section, and confirm the approach also supports other confirm modals.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100