oxidecomputer / oxidecomputer/console

Make clear serial console isn't supposed to work in MSW mode

Open
#2,071 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
228
Forks
22
Avg merge
19h 42m
Merged PRs (30d)
32

Description

There is a to-do to handle errors on connection failure. That would sort of cover us here, but we could include a special message when process.env.MSW is true.

https://github.com/oxidecomputer/console/blob/7490104a3509b4d58afcc03fb9cee425caea24cc/app/pages/project/instances/instance/SerialConsolePage.tsx#L57-L67

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in app/pages/project/instances/instance/SerialConsolePage.tsx at lines 57-67 and inspect how connection failures are handled. Add the MSW-specific explanation requested by the issue, using the existing connection-failure path; done means users are clearly told that serial console is not expected to work in MSW mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.