oxidecomputer / oxidecomputer/console

Quick actions click to close doesn't work on bottom

Open
#1,720 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
228
Forks
22
Avg merge
19h 42m
Merged PRs (30d)
32

Description

It's because the dialog has a set margin rather than getting its height from its contents.

2023-08-09-quick-menu-click-bug

Screenshot 2023-08-09 at 2 49 33 PM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the quick actions dialog and reproduce the bottom click-to-close failure shown in the attached screenshots. Inspect how the dialog's margin and content height are set; done means the dialog fits its contents and clicking the bottom close area works reliably.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.