oxidecomputer / oxidecomputer/console
Validate both-or-neither on signing keypair on IdP create
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 228
- Forks
- 22
- Avg merge
- 19h 42m
- Merged PRs (30d)
- 32
Description
In the IdP create UI, we have two file fields for the signing keypair. In the API, these are optional as a pair. If (as concluded in https://github.com/oxidecomputer/omicron/issues/3155 after some confusion on my part) we do want to have first-class support for the no-keypair option, I think the UI should be more explicit about how you need either both or neither. Maybe something that collapses both together, or a radio, or something. Even if we don't do that, we should validate both-or-neither client-side with a helpful message.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the IdP create UI and review the two signing-keypair file fields, then compare their behavior with the API's optional-as-a-pair definition in nexus/types/src/external_api/params.rs. Done means the UI clearly supports both files or neither and shows a helpful client-side message when only one is provided.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100