oxidecomputer / oxidecomputer/console

SSH key polish notes

Open
#1,561 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
228
Forks
22
Avg merge
19h 42m
Merged PRs (30d)
32

Description

A couple minor polish issues from interacting with the console:

  1. When adding an SSH key, the form path (settings/ssh-keys-new) is pushed onto the history stack causing the navigation via back / forward to repop the "Add SSH key" form. My assumption would be that after successfully adding an SSH key, the back button would return me to the page I was on prior to the SSH keys page. A similar behavior occurs if you repeatedly open / close the "Add SSH key" form, the back / forward actions will replay each interaction
  2. On the instance create screen "Authentication > SSH keys" is missing a tooltip message. Currently the label reads "hello"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the settings/ssh-keys-new flow and reproduce adding a key and repeatedly opening and closing the form while using back and forward navigation. Then inspect the instance create screen's Authentication > SSH keys label; done means history no longer replays form interactions and the label has a meaningful tooltip instead of "hello".

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.