oxidecomputer / oxidecomputer/console
Item highlighting is weird in `TopBarPicker`
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 228
- Forks
- 22
- Avg merge
- 19h 42m
- Merged PRs (30d)
- 32
Description
Noticed this while working on #1395, but was able to repro on main before merging that, so it's just a problem with our CSS. Mouse hover produces the expected highlighting but keyboard doesn't. Keyboard lets you highlight the entire thing for some reason but not individual elements.
I think it's specific to that selected item style because the table actions one works fine:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the TopBarPicker component and its selected-item CSS, then compare it with the table actions selected-item style that works correctly. Reproduce the issue with mouse and keyboard navigation, and confirm that keyboard focus highlights individual items rather than the entire picker.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100