oxidecomputer / oxidecomputer/console

Lower-down error boundary for more localized display of API errors

Open
#1,040 4 comments 0 reactions 1 assignee View on GitHub

@david-crespo is already working on this.

Since Jul 27, 2022.

polish
Dominant language
TypeScript
Stars
228
Forks
22
Avg merge
19h 42m
Merged PRs (30d)
32

Description

Right now we bubble up any API 404 to a full-page 404.

https://github.com/oxidecomputer/console/blob/e8396778cc7d5557fffacfff9e59c123fd4b4a68/app/components/ErrorBoundary.tsx#L8-L11

That is often going to be overkill. We ran into a case in a run-through where the serial console API call 404ed. It would have been much better to contain the error message to the part of the page where we want to display the serial console. The good news is we should be able to do this pretty easily with another error boundary that wraps only the table or detail view or tab contents or the <Outlet /> in a layout.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.