oxidecomputer / oxidecomputer/cockroach
delete or un-multitenant `TestTenantStatementTimeoutAdmissionQueueCancelation`
Open
Nobody has claimed this yet.
cleanup
- Dominant language
- Go
- Stars
- 34
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
Not immediately clear to me if this test is testing something we otherwise wouldn't be if we deleted it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pkg/sql/run_control_test.go at lines 748-756 and inspect TestTenantStatementTimeoutAdmissionQueueCancelation. Determine what behavior the test covers and whether deleting it or removing its multitenant setup would leave that behavior untested. Done means the test's coverage implications are understood and one of the two scoped changes is justified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100