oxidecomputer / oxidecomputer/cockroach
inspect/delete `TestTenantClusterFlow`
Open
Nobody has claimed this yet.
cleanup
- Dominant language
- Go
- Stars
- 34
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
There's a similarish TestClusterFlow above, figure out if the two tests are more or less equivalent, and delete the multitenant one we deleted the underlying CCL-licensed code for.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open pkg/sql/flowinfra/cluster_test.go at the referenced lines and compare TestTenantClusterFlow with the nearby TestClusterFlow. Determine whether the tests are effectively equivalent, then remove the multitenant test if so. Run the relevant tests to confirm the file still passes after the deletion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100