oxidecomputer / oxidecomputer/cockroach

delete or un-multitenant `TestTransientClusterMultitenant`

Open
#7 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cleanup
Dominant language
Go
Stars
34
Forks
8
PR merge metrics
No merged PRs in 30d

Description

https://github.com/oxidecomputer/cockroach/blob/afda0c16c882a426eda6bd8791d7c0f3da6eaadb/pkg/cli/democluster/demo_cluster_test.go#L257-L258

Not immediately clear to me if this test is testing something we otherwise wouldn't be if we deleted it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at pkg/cli/democluster/demo_cluster_test.go#L257-L258 and inspect TestTransientClusterMultitenant, then compare what behavior it covers with the surrounding tests. Done means either removing the redundant test or un-multitenanting it without losing unique coverage, with the relevant test suite still passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.