oxidecomputer / oxidecomputer/cockroach

test flake in pkg/migration/migrationmanager: `TestAlreadyRunningJobsAreHandledProperly`

Open
#62 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

flake
Dominant language
Go
Stars
34
Forks
8
PR merge metrics
No merged PRs in 30d

Description

https://github.com/oxidecomputer/cockroach/pull/51/checks?check_run_id=66502424619

https://buildomat.eng.oxide.computer/wg/0/details/01KKCDM2XB7GJGNBQNPT856X6C/P46QqdufG9OeSxlfhzxXAWGYVO8qGjDjazAZt3UfHb6HKRpz/01KKCDN0NP8BEDTNWCXZ98KST1#S3167

This test normally takes ~0.5s to run on its own but periodically hits the 60-minute timeout. Not great!

This can be reproduced with:

gmake stress PKG=./pkg/migration/migrationmanager TESTS=TestAlreadyRunningJobsAreHandledProperly TESTTIMEOUT=1m

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with TestAlreadyRunningJobsAreHandledProperly in pkg/migration/migrationmanager and reproduce the flake using the provided gmake stress command with TESTTIMEOUT=1m. Trace why the test can run until the timeout, then verify the test completes reliably without hitting the timeout.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.