oxidecomputer / oxidecomputer/cockroach
skipped tests due to no `GetTotalMemory` implementation
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 34
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
We don't implement this function in our patched gosigar which doesn't affect runtime (as we're using Cockroach, anyway), but we have to skip a couple of tests (skips added in https://github.com/oxidecomputer/cockroach/commit/f46ecb203ea329f1a96699a35cfb60599a61b43a).
Presumably the metrics recorder is what continually logs "not implemented on illumos" every 10s or so during runtime.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pkg/server/status/recorder.go around lines 627-632 and inspect the repository's patched gosigar implementation of GetTotalMemory. Review the commit that added the skipped tests to understand the expected behavior, then confirm the affected tests pass without skips and that the repeated illumos message is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, observability, operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100