oxc-project / oxc-project/backlog

Fix unsound code in formatter

Open
#208 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
7
Forks
0
PR merge metrics
No merged PRs in 30d

Description

https://github.com/oxc-project/oxc/pull/24372 added a TODO comment about some unsound code in minifier.

@Dunqing and I both unclear how to fix it. But fix it we must!

Opening this issue so we don't forget.

It might become easier to solve one we get rid of arena allocation in formatter.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the TODO about unsound code introduced by PR #24372 in the formatter or minifier. Read the surrounding arena-allocation code and related history to establish the unsafe assumption; the issue is done when that unsound code has a reviewed, validated replacement.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.