owncloud / owncloud/user_ldap

[QA] occ user:sync prints wrong diagonstics after disabling/reenabling users

Open
#655 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
17
Forks
19
Avg merge
11h 40m
Merged PRs (30d)
2

Description

Seen with user_ldap-0.15.3-RC3 at server 10.8.0-beta2

Use the Edit LDAP Query in the User tab to filter down to a few users only. E.g.
(|(&(objectclass=inetOrgPerson)(givenname=Th*))) then run
`occ user:sync -c -m disable -r "OCA\User_LDAP\User_Proxy"

-> Most users become disabled. Only e.g. "Third Ldapuser" can log in. OK

broaden the filter back to normal wiith e.g. (|(&(objectclass=inetOrgPerson)(givenname=*))) and re-run the user sync without(!) the -r flag.
-> No users users become re-enabled. OK
Then re-run the iser sync with the -r flag, -> All users become re-enabled and can log in.

Repeat a few times with and without -r.
At some point occ user:sync -c -m disable -r "OCA\User_LDAP\User_Proxy" prints

...
e77866d0-72f1-103b-8427-9dea2428f1ef, One thousand and ninety-second Ldapuser, u1092@example.org skipped, already disabled
e77a3212-72f1-103b-8428-9dea2428f1ef, One thousand and ninety-third Ldapuser, u1093@example.org skipped, already disabled
e77bec7e-72f1-103b-8429-9dea2428f1ef, One thousand and ninety-fourth Ldapuser, u1094@example.org skipped, already disabled
e77dcde6-72f1-103b-842a-9dea2428f1ef, One thousand and ninety-fifth Ldapuser, u1095@example.org skipped, already disabled
e77f7826-72f1-103b-842b-9dea2428f1ef, One thousand and ninety-sixth Ldapuser, u1096@example.org skipped, already disabled
e780fa0c-72f1-103b-842c-9dea2428f1ef, One thousand and ninety-seventh Ldapuser, u1097@example.org skipped, already disabled
e7827a1c-72f1-103b-842d-9dea2428f1ef, One thousand and ninety-eighth Ldapuser, u1098@example.org skipped, already disabled
e7840a6c-72f1-103b-842e-9dea2428f1ef, One thousand and ninety-ninth Ldapuser, u1099@example.org skipped, already disabled

No existing accounts to re-enable.

Inserting new and updating all known users from OCA\User_LDAP\User_Proxy ...
 1104/1104 [============================] 100%


Sync of users finished, encountered 0 errors.

This indicates that e.g. user u1099@example.org is disabled.
Try log in using that email address, the user can log in correctly.

Expected behaviour: The message should say "... skipped, already enabled"
Switching this back and forth a few times, a

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the User tab's LDAP filter and the occ user:sync command using OCA\User_LDAP\User_Proxy, switching the -r flag as described. Trace the sync diagnostics for users whose login state changes, then verify that the reported enabled or disabled state matches whether the account can log in.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.