Deleting file is not possible if a file is shared to LDAP group and Login Filter doesn't contains uid attribute
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 17
- Forks
- 19
- Avg merge
- 11h 40m
- Merged PRs (30d)
- 2
Description
Original issue: https://github.com/owncloud/core/issues/24206 by @rogerfv1
Steps to reproduce
- Enable user_ldap plugin and set memberUID for Group-Member association.
- Edit LDAP Login Attributes so that it doesn't use the uid attribute. You can use mail attribute instead of uid.
- Create a ldap group and assign 2 members (user1 and user2) using memberUID.
- With user1 share any file to ldap group.
- With user2 try to delete the file shared by user1.
Expected behaviour
User2 should be able to delete the file shared by user1.
Actual behaviour
User2 can't delete the file shared by user1.
Error deleting file ""teste2_grupo.txt".
Server configuration
Operating system: Debian 7 x86_64
Web server: Apache 2.2
Database: Postgresql 9.4
PHP version: 5.4.45-0+deb7u2
ownCloud version: 9.0.1
Updated from an older ownCloud or fresh install: Updated
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the LDAP group-sharing scenario described in the issue, using a login filter without the uid attribute and memberUID for group membership. Trace the delete-file permission check and compare the user identity used for sharing with the identity returned by the LDAP configuration. Done means user2 can delete the shared file and the regression is covered by an appropriate test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authorization, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100