Handle logging of "invalid quota <> for LDAP user" differently
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 17
- Forks
- 19
- Avg merge
- 11h 40m
- Merged PRs (30d)
- 2
Description
As described in the forums and another (closed) issue here, the user_ldap app spams the owncloud.log if no quota is set for a certain user.
The log line looks as follows:
{"reqId":"mdn5o8QncCyPidvVjTMn","level":3,"time":"2018-08-21T09:30:03+02:00","remoteAddr":""
,"user":"--","app":"user_ldap","method":"--","url":"--",
"message":"Invalid quota <> for LDAP user "}
I think this should be handled differently. To be precise I wouldn't treat "no quota" as an invalid one. From what I've experienced in customer projects with owncloud and nextcloud, it's relatively common not to set a quota at all (depends on the project and users of course). This is certainly not a best practice but the log file shouldn't be spammed in this case either in my opinion.
Feel free to suggest different approaches as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the LDAP quota validation and logging path in the user_ldap app, then reproduce the case with an LDAP user whose quota is unset. Done means an unset quota no longer spams owncloud.log while genuinely invalid quota values continue to be handled appropriately.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100